- improve visibility of the show
- prevent glitches in the show execution
- each gameobject only exists for a very short duration, so there
should be no relevant performance impacts
* fix(DB/game_event): revert squash 11.0.0 changes
- this reverts the dates in the table to COMMIT:
- f0e6b0f1ab
- (last commit before squash 11.0.0)
* add missing ticks
- to me this hook should obviously provide an option to overwrite
the InstanceScript pointer
- this is e.g. beeing used by mod-eluna (but currently broken)
fix(Scripts/Midsummer): fix handling of unwanted npc and gameobject spawns
- properly spawn bonfire spell focus for city bonfires
- properly despawn unwanted creatures and gameobjects which are spawned
by linked traps
- all midsummer bonfire gameobjects have a linked trap "181290 Midsummer Bonfire Spawn Trap"
- the trap is linked to the spell "28784 Summon Midsummer Bonfire Bunnies" which then spawns
npc "16592 Midsummer Bonfire", npc "16606 Midsummer Bonfire Despawner" and gameobject
"181371 Midsummer Bonfire Spell Focus" i have no idea how this trap is beeing triggered,
but it's doing only harm right now
fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN_ANY_STATE
- this allows flagging quests so that they are allowed to fail in Player::FailQuest()
independant of their current state
- update quest 853 accordingly as a first use case
* fix(Core/Mail): calculate unReadMails and m_nextMailDelivereTime using mail cache
- these values were grepped directly from DB before
-> this change was introduced with azerothcore/azerothcore-wotlk#3420
- the whole mailing system relies on the mails beeing cached in the core
-> these get stored in DB regularly or on specific events
- so apparently the DB is not always in sync with the current mail cache state of the core
-> so grepping data directly from DB is not a good idea at this point
* Update PlayerUpdates.cpp
* fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley
I've been "collecting" these in the DB for a while, now it's time to move
these spawns to the AV script and actually spawn them.
* add 2 additional generic gameobjects
* init sql file for fireworks spectacular - add entry in game_event
* add missing delete statement
* add gameobjects 180698 'Party Table, 180699 'Festive Keg, 180700 'Hay Bale 1'
* update comment, add gameobject 180754 Toasting Goblet
- todo: pooling (?) - the tables are quite full
- todo: why are there tables missing? e.g. below:
.go ga 82615
* add gameobject 180905 'Festive Mug'
* add gameobjects 'Firework, Show, Type%'
* add vendors
* add revelers and bruisers
TODO: also add 15906 'Ironforge Reveler'
* remove '%Firework Show%' spawns
- these will be spawned temporarily via script
* add firework gameobject SmartAI
* WIP stormwind fireworks show
steps to test the show:
.go xyz -8984 498 96 0
.gob add temp 180749
* improve handling of fireworks show, add gameobject 180749 'Cheer Speaker' spawns
how to test:
.go ga 64640
.event start 72
* prepare fetching correct show based on map+zone
* introduce typedef for FireworkShow
* Add Teldrassil show
.go ga 64651
.event start 72
* fix Teldrassil and Stormwind shows, add initShow() debug message, replace magic numbers for fireworkShow sizes
- these were broken due to an error in my txt parsing script
* add Shattrath show
.go c 139914
.event start 72
* add Silvermoon show
.go ga 64670
.event start 72
* add Booty Bay show
.go ga 64630
.event start 72
* add Thunder Bluff show, add Exodar show, set firework gameobjects active, update comments, remove _maxCount
* add Underciy show
.go ga 64641
.event start 72
* fix Undercity show indexes
* move code from midsummer.cpp to new file firework_show.cpp
* add Orgrimmar show
.go ga 64647
.event start 72
* add Ironforge show
.go ga 64634
.event start 72
* update shows from sniff parses using fixed export script
* update 'Party Table, 'Festive Keg' and 'Hay Bale 1' spawns with additional sniffs
* update 'Toasting Goblet' spawns with additional sniffs
* update 'Festive Mug' spawns with additional sniffs
* update 'Fireworks Revelers' spawns with additional sniffs
* remove duplicate AND from sql file
* attempt moving FireworkShows to the heap
* start firework show at the full hour and also handle late starts correctly
- also perform a minor cleanup
* do not touch gameobject with guid 16586 which is linked to harvest festival
* move firework_show.cpp to subfolder firework_show
* move firework_show arrays to seperate header files
* update show handling, still not final
* update for new struct design, Teldrassil show running correctly already
* update remaining shows for new firework show structs
* rename go_cheer_speaker to go_firework_show
* update debug / error messages
* update all firework shows for local spawnIndex handling
* spawn 'Toasting Goblet's for 10min after show ende
* add reveler SAI and make revelers cheer on show end
* remove log_error messages
* add comment for festive mugs
* Update firework_show.cpp
* add missing include for uint32
* replace an uint32 with an int
* revert unintended changes in midsummer.cpp
* add #include "GameObjectScript.h"
* remove ThunderBluff Reveler spawns with wandering movement
- these probably should have waypoints instead or just got parsed incorrectly
- it should be safe to remove these for now and probably investigage this further later on
* update function names
- this just broke the whole purpose of setActive(true) if the
gameobjects is still not really beeing set active afterwards
- GetGridActivationRange() returns 0.0f for gameobjects anyways
- so CalculateCellArea() will result in the minimal cell area
around the gameobject's position
- if the cell around the gameobject should not be updated, the
gameobject should not have been set active in the first place
- m_goData must be assigned before Create() is beeing called
- otherwise GetScriptId() can't load the correct scriptiD
in Create()
- all in all this is now more in line with how it's beeing
done in Creature.cpp
* fix(DB/Gameobject): Sniffed Values for 'Forge' spawns
* Update rev_1711633613954464100.sql
Just to trigger CI again
* Update rev_1711633613954464100.sql
* fix(DB/Gameobject): Sniffed Values for 'Mighty Blaze' spawns
* fix spawnMask - why is this so often wrong in sql parses
* remove already sniffed 534 spawns
* fix(Core/PVP): Fix OutDoorPVP CustomSpell handling
- the function HandleCustomSpell() should only return
true if it actually handled a spell
* comment unused parameter
fix(Core): Prevent gift wrapping of items with duration
- remaining duration is not beeing stored in character_gifts
- gift wrapping of items with duration preserved
them infinitely
* fix(DB/Gameobject): Sniffed Values for 'Subway Bench'
- they were also all using the same ID before but actually
each spawn uses a different ID
* reset spawnMask from 3 to 1
sudlud