Commit Graph
19504 Commits
Author SHA1 Message Date
mpfansandsudlud d93aa1eb30 fix(Core/Vehicle): avoid Vehicle-kit use-after-free in TeleportVehicle (#26116)
Co-authored-by: sudlud <[email protected]>
2026-09-12 23:09:33 +02:00
MacWarrior a20beb0a80 feat(Core/Scripting): Add spell aura exclusivity hook (#26565) 2026-09-12 22:33:58 +02:00
f7759071a0 fix(Scripts/SlavePens): Fixed the loot permissions for boss_ahune's chest in Slave Pens (#27117)
Co-authored-by: sogladev <[email protected]>
Co-authored-by: sudlud <[email protected]>
2026-09-12 22:17:00 +02:00
moostigre 275ce1e609 fix(Scripts/Silverpine): prevent duplicate Pyrewood Ambush events (#26832) 2026-09-12 21:47:29 +02:00
Saqra1 e826d9f6dc fix(Core/Pets): Resume chase after deferred casts (#27623) 2026-09-12 16:43:59 -03:00
隐如仙 568ea12bbe fix(Core/Movement): Prevent waypoints from passing through the ground when using SmoothTransition (#27107) 2026-09-12 21:22:11 +02:00
github-actions[bot] 8516fd49a6 chore(DB): import pending files
Referenced commit(s): b6f62f5228
2026-09-12 19:09:31 +00:00
sogladev b6f62f5228 fix(DB/Creature): set NO_PARRY_HASTEN for t7-t10 bosses (#27625) 2026-09-12 16:06:12 -03:00
AndrewandClaude Opus 5 5054796f66 fix(Core/Spells): stop forced casts from inheriting the caster as their destination (#27621)
Spell::EffectForceCast always handed the forced cast the original caster
as its unit target. When the triggered spell takes no unit target but
does need a destination, Spell::InitExplicitTargets turns that unit
target into the destination, so the forced cast resolves against the
original caster instead of against the unit that was forced to cast it.

Only pass the unit target when the triggered spell's explicit target mask
accepts one, which is the same test InitExplicitTargets applies before
discarding it.

Twelve spells in the client data force-cast a spell that needs a
destination but takes no unit target: 42073, 48759, 52187, 57838, 58566,
62207, 62301, 62921, 64088, 64598, 69839 and 70882. Seven of them place
their summon somewhere new - 48759, 52187, 57838, 58566, 62207, 62921 and
64088, whose triggers summon at the destination itself or at a fixed
offset from it. The rest do not move: 42073 force-casts on itself,
69839's force-cast effect is prevented by a spell script, and 70882's
trigger overwrites the destination with TARGET_DEST_CASTER.

62301 and 64598 are the last two. Their trigger 62293 inherited the
destination like the others, but a spell_info correction forcing its
TargetB to TARGET_DEST_CASTER had SelectImplicitCasterDestTargets
overwrite it with the forced caster afterwards, so Algalon's craters
landed correctly in spite of the bug. With the root cause fixed that
correction is dead code and goes with it; the fallback destination
InitExplicitTargets now picks is the same position the correction used to
write, so nothing moves in-game.

TestEffects_ForceCastDestination covers both trigger shapes: 62221 and
62293 summoning at the destination itself, and 48757 summoning at an
offset from it.

Co-Authored-By: Claude Opus 5 <[email protected]>
2026-09-12 15:38:34 -03:00
github-actions[bot] 4a91be84ab chore(DB): import pending files
Referenced commit(s): 186dfc7fa1
2026-09-12 17:48:15 +00:00
Andrew 186dfc7fa1 fix(DB/Ulduar): correct 10-man and 25-man loot pools (#27624) 2026-09-12 14:47:05 -03:00
github-actions[bot] ae7ed2f096 chore(DB): import pending files
Referenced commit(s): 83ad15d755
2026-09-12 15:14:52 +00:00
Andrew 09c70f28a2 fix(Scripts/Ulduar): stop Flame Leviathan saving the raid on pull (#27622) 2026-09-12 12:13:28 -03:00
83ad15d755 fix(DB/Quest): Summon Lord Kragaru from the Serpent Statue (#27611)
Co-authored-by: Aokromes <[email protected]>
Co-authored-by: Dr-J <[email protected]>
Co-authored-by: Gultask <[email protected]>
2026-09-12 12:08:45 -03:00
sogladev c3e3d216bf fix(Core/Spells): allow paladin auras from different casters to coexist (#27509) 2026-09-12 16:57:59 +02:00
Saqra1 708403602a fix(Core/Spells): Prevent taunts from affecting totems (#27601) 2026-09-12 16:57:34 +02:00
Andrew f0f08f1331 fix(Scripts/Ulduar): cast Razorscale's Wing Buffet once per grounding (#27616) 2026-09-12 11:14:12 -03:00
Saqra1 74487848ea fix(Core/Pets): Stop moving for autocast channels (#27564) 2026-09-12 14:51:19 +02:00
Mark Klitgaard-BrodersenandAlsoNotMehh 553012d86f fix(Core/Spells): load all spell_custom_attr rows (#27365)
DatabaseWorkerPool::Query already advances to the first row as part of
its result guard, so `for (count = 0; result->NextRow(); ++count)` steps
past it and the first row is never applied. Use the do/while idiom that
the other 16 loaders in this file already use.

On a stock DB the skipped row is spell 53 (Backstab, rank 1), the lowest
spell_id in the table, which therefore never receives
SPELL_ATTR0_CU_REQ_CASTER_BEHIND_TARGET and can be cast from the front.
The startup line also under-reports by one.

The same fix was submitted independently as #27416, which also provided
the in-game confirmation.

Co-authored-by: AlsoNotMehh <[email protected]>
2026-09-12 14:43:18 +02:00
github-actions[bot] 01c58df5bd chore(DB): import pending files
Referenced commit(s): ab951fb735
2026-09-12 11:46:28 +00:00
moostigreandsudlud ab951fb735 fix(DB/Scholomance): guarantee one rare loot from Lord Alexei Barov (#27270)
Co-authored-by: sudlud <[email protected]>
2026-09-12 13:44:59 +02:00
Andrew c0e6272af9 fix(Scripts/Ulduar): make Yogg-Saron's Laughing Skulls respect line of sight (#27614) 2026-09-11 21:28:07 -03:00
github-actions[bot] 3ef3432cb6 chore(DB): import pending files
Referenced commit(s): 968cf32814
2026-09-12 00:17:15 +00:00
Pierre-Luc Brunet 968cf32814 fix(DB/SAI): drop Mogg's link to an undefined event (#27609) 2026-09-11 21:16:14 -03:00
CrowandClaude Opus 5 479848ec5d fix(Scripts/MagtheridonsLair): anchor the release countdown to the Channeler pull (#27600)
Co-authored-by: Claude Opus 5 <[email protected]>
2026-09-11 20:57:18 -03:00
github-actions[bot] bd0c624eb2 chore(DB): import pending files
Referenced commit(s): 875358dc2a
2026-09-11 22:46:28 +00:00
EricksOliveiraandRocco Silipo 875358dc2a fix(Scripts/Ulduar): keep Razorscale grounded during her permanent ground phase (#27610)
Co-authored-by: Rocco Silipo <[email protected]>
2026-09-11 19:45:14 -03:00
github-actions[bot] 985c747291 chore(DB): import pending files
Referenced commit(s): 9b7a65535b
2026-09-11 21:41:23 +00:00
b0bb3ae8bd fix(DB/Ulduar): award Stokin' the Furnace on Ignis kill (#27598)
Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: Andrew <[email protected]>
2026-09-11 18:40:53 -03:00
ØyvindandClaude Fable 5.1 9b7a65535b fix(Core/Item): unlock openable item on the client when opened while dead (#27431)
Co-authored-by: Claude Fable 5.1 <[email protected]>
2026-09-11 18:40:21 -03:00
39ffb837d5 feat(Core/Deps): require Boost.Thread alongside the other Boost components (#27584)
Co-authored-by: sudlud <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
2026-09-11 21:42:11 +02:00
90bccf4fa6 fix(Shared/DBC): keep DBC string when DB override column is empty (#27581)
Co-authored-by: Alvin Zhu <[email protected]>
Co-authored-by: sudlud <[email protected]>
Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
2026-09-11 14:07:24 +02:00
Keleborn c1893c0e51 fix(Core/Database): allow reopening a DatabaseWorkerPool after a failed Open() (#27585) 2026-09-11 13:08:27 +02:00
527e91b9b2 fix(Core/Chat): accept uppercase link colors and the 'found' tag (#27580)
Co-authored-by: bashermens <[email protected]>
Co-authored-by: sudlud <[email protected]>
2026-09-11 12:53:45 +02:00
AlsoNotMehhandSkjalf dbacb5bb1b fix(Scripts/Ulduar): keep Kologarn's corpse as the bridge across instance reloads (#27557)
Co-authored-by: Skjalf <[email protected]>
2026-09-11 00:45:42 -03:00
Andrew d0825055c9 docs(agents): state the PR title convention inline (#27568) 2026-09-10 22:56:02 -03:00
4cc1210a11 fix(Scripts/IcecrownCitadel): restore flight animations for Sindragosa, Rimefang, Spinestalker and Spire Frostwyrm (#26738)
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: sudlud <[email protected]>
2026-09-10 22:10:55 -03:00
Andrewandsogladev 65d564c848 fix(Core/Creature): Keep a spell's own recovery time on category cooldowns (#27595)
Co-authored-by: sogladev <[email protected]>
2026-09-10 20:30:23 -03:00
Andrew b34efa2abb docs(agents): set flags_extra on every difficulty entry (#27586) 2026-09-10 19:13:35 -03:00
github-actions[bot] c9a5efc491 chore(DB): import pending files
Referenced commit(s): c181b77d3c
2026-09-10 18:10:27 +00:00
Gultask c181b77d3c fix(DB/SAI): Attempt another fix for Sky Darkener accumulation (#27597) 2026-09-10 15:09:26 -03:00
github-actions[bot] b4a7c2ddc0 chore(DB): import pending files
Referenced commit(s): ff8ed0c7f2
2026-09-10 16:53:40 +00:00
Rocco Silipo ff8ed0c7f2 fix(DB/Ulduar): Void Zone summoned during XT-002 Deconstructor Hard Mode doen't stay in combat with the players. (#27596) 2026-09-10 18:52:28 +02:00
github-actions[bot] 2fc1abea29 chore(DB): import pending files
Referenced commit(s): 4ddcea8503
2026-09-10 09:48:13 +00:00
Andrew 4ddcea8503 fix(DB/Creature): stop Mimiron DB Target entering combat (#27594) 2026-09-10 06:47:12 -03:00
github-actions[bot] b3e01ee2ca chore(DB): import pending files
Referenced commit(s): f4763cc9eb
2026-09-10 08:22:49 +00:00
Andrew f4763cc9eb fix(Scripts/Ulduar): give Flame Leviathan's Freya's Ward lashers their own targeting AI (#27567) 2026-09-10 05:21:40 -03:00
github-actions[bot] 251368adb3 chore(DB): import pending files
Referenced commit(s): 02926c2bda
2026-09-10 01:31:57 +00:00
Andrew 76bc632dc0 fix(DB/Creature): sync Freya's 25-man HARD_RESET flag (#27587) 2026-09-09 22:31:18 -03:00
Andrew 02926c2bda fix(Scripts/Ulduar): stop XT-002 summoning adds after death (#27589) 2026-09-09 22:30:59 -03:00