mirror/azerothcore-wotlk
1
0
Fork 1
mirror of https://gitcode.com/GitHub_Trending/az/azerothcore-wotlk.git synced 2026-10-10 07:06:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/Skills): use progressive crafting skill-up chance (#27219)

Browse Source
This commit is contained in:
moostigre
2026-09-05 21:18:01 +02:00
committed by GitHub
parent f7aa302dfc
commit a960ecb88c
2 changed files with 29 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/apps/worldserver/worldserver.conf.dist
+4 -1
View File
@@ -2368,7 +2368,10 @@ SkillGain.Weapon = 1
# SkillChance.Yellow
# SkillChance.Green
# SkillChance.Grey
# Description: Chance to increase skill based on recipe color.
# Description: Chance to increase skill based on difficulty.
# Crafting recipes interpolate between the orange and grey
# chances. Yellow and green chances apply to gathering and
# scripted skill gains.
# Default: 100 - (SkillChance.Orange)
# 75 - (SkillChance.Yellow)
# 25 - (SkillChance.Green)
src/server/game/Entities/Player/PlayerUpdates.cpp
+25 -6
View File
@@ -764,6 +764,28 @@ inline int SkillGainChance(uint32 SkillValue, uint32 GrayLevel,
return sWorld->getIntConfig(CONFIG_SKILL_CHANCE_ORANGE) * 10;
}
inline int32 CraftSkillGainChance(uint32 skillValue, uint32 grayLevel, uint32 yellowLevel)
{
int32 orangeChance = sWorld->getIntConfig(CONFIG_SKILL_CHANCE_ORANGE) * 10;
int32 grayChance = sWorld->getIntConfig(CONFIG_SKILL_CHANCE_GREY) * 10;
// Invalid or equal thresholds cannot be interpolated. Preserve the
// previous orange/gray boundary behavior for malformed DBC entries.
if (grayLevel <= yellowLevel)
return skillValue < grayLevel ? orangeChance : grayChance;
if (skillValue <= yellowLevel)
return orangeChance;
if (skillValue >= grayLevel)
return grayChance;
// Crafting skill-up chance falls linearly from orange at the yellow
// threshold to gray at the gray threshold. The green threshold is the
// midpoint of that range and therefore has a 50% chance by default.
return grayChance + int32(int64(grayLevel - skillValue) * (orangeChance - grayChance) /
(grayLevel - yellowLevel));
}
bool Player::UpdateGatherSkill(uint32 SkillId, uint32 SkillValue,
uint32 RedLevel, uint32 Multiplicator)
{
@@ -855,12 +877,9 @@ bool Player::UpdateCraftSkill(uint32 spellid)
return UpdateSkillPro(
_spell_idx->second->SkillLine,
SkillGainChance(SkillValue,
_spell_idx->second->TrivialSkillLineRankHigh,
(_spell_idx->second->TrivialSkillLineRankHigh +
_spell_idx->second->TrivialSkillLineRankLow) /
2,
_spell_idx->second->TrivialSkillLineRankLow),
CraftSkillGainChance(SkillValue,
_spell_idx->second->TrivialSkillLineRankHigh,
_spell_idx->second->TrivialSkillLineRankLow),
craft_skill_gain);
}
}