Commit Graph

166 Commits

Author SHA1 Message Date
Benjamin Jackson adff3c3846 fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. (#19664)
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"

This reverts commit cc2ef9d6dd.
2024-08-17 20:29:21 -03:00
Benjamin Jackson 67010623a0 fix(Core): Adjustments to summoning ritual object handling. (#19600)
* Init.

* Allow self-summoning.

* Revert unintended change.

Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Benjamin Jackson cc2ef9d6dd fix(Core/Spells): Adjust ownership and follow logic for guardian summons. (#19599)
* Init.

* Remove totem ownership transfer.
2024-08-13 11:53:43 -03:00
Kitzunu e4df159f5c refactor(Core/Chat): Move SendNotification to ChatHander (#19491)
* refactor(Core/Chat): Move SendNotification to ChatHander

* Update Battleground.cpp

* fix build

* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Kitzunu 793f87fd61 fix(Core/GameObject): Use correct spell at meeting stone (#19311)
* fix(Core/GameObject): Use correct spell at meeting stone

* cleanup
2024-07-09 19:39:58 -03:00
Mykhailo Redko 33f951d742 fix(Core/Spells): Fixed work of sobering spells and other improvements for drunk system (#18390)
* fix(Core/Spells): Fix sobering spells and possible uint8 overflow/underflow in SPELL_EFFECT_INEBRIATE handler.

* fix(Core/Spells): Improvements for SPELL_AURA_MOD_FAKE_INEBRIATE handling
2024-03-20 01:45:01 -03:00
Nathan Handley df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley 425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Kitzunu 7a859da266 fix(Script/Spell): Vanish Purge behavior (#18127) 2024-01-07 12:03:53 -03:00
Alethrion b2fcc1babf fix(Core/Unit): Remove delay for Conflagrate aura state (#18068)
Removes ConflagrateAuraStateDelayEvent

Cherry-picked from: https://github.com/TrinityCore/TrinityCore/commit/e27c385b48fce359a168d602dabae8c55fa85563

Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com>
2024-01-01 07:59:23 -03:00
Tristan 'Natrist' Cormier ac676f87ab chore(Core/Player): remove unused AnticheatSetSkipOnePacketForASH() function (#17947) 2023-12-09 01:09:52 +01:00
Andrew 5a4fdc7de4 fix(Core/Spells): Banish should only be dispelled by Mass Dispel (#17703)
* fix(Core/Spells): Banish should only be dispelled by Mass Dispel

* Update Unit.cpp

* Update Unit.cpp
2023-11-14 16:27:37 +01:00
Kitzunu bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Kitzunu f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG 60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
KJack 99bf49e0dd Fix (core/SpellEffects): Don't randomize summoned guardian position if target is in the DB (#17506)
* Doesn't randomize placement of guardian summons if the target position was specified in the DB

* Add `HasRadius()` check

* Add check for zero-radius effects, update IF condition style

* Accept IF condition statement suggestion

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-17 00:07:47 +02:00
Skjalf cc60bc0c35 fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to… (#17348)
* fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to engineers

* Update SpellEffects.cpp

* Update spell_item.cpp
2023-09-25 06:10:23 -03:00
UltraNix c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
Synful-Syn f84d786df0 chore(Scripts/Spells): Reduce the amount of player checks (#16719)
merge some player checks
2023-07-17 08:24:18 -03:00
Tereneckla a234314d35 fix (Core/Spells) Apply Seals of Pure talent to Seal of Vengeance/Corruption again (#16559)
Update SpellEffects.cpp
2023-06-30 09:18:02 -03:00
Tereneckla 6fe6f891fc Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal… (#15938)
* Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193)"

This reverts commit 88401360ab.

* Keep Divine Storm in SPELLFAMILIY_PALADIN case

* Update SpellEffects.cpp
2023-05-13 14:41:27 -03:00
Kitzunu 7eafd35190 chore(Spell/Effects): Small improvement to EffectDistract (#15920)
* chore(Spell/Effects): Small improvement to EffectDistract

* Update SpellEffects.cpp
2023-04-21 07:41:01 -03:00
UltraNix 88401360ab fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193) 2023-03-04 17:40:33 -03:00
UltraNix e3ed2e99e6 fix(Core/Spells): Goblin Rocket Helmet should not cause auto-attack. (#15207) 2023-03-04 17:39:05 -03:00
Kitzunu f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Skjalf 2aeeee9c83 fix(Core/Spells): Remove all hardcoded restrictions for pick pocket sp… (#14788)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-01-29 12:12:21 -03:00
M'Dic 437d93926f fix (core): macos12 depreciation workflow error / security CWE-120 (#14746)
* fix (core): macos12 depreciation workflow error

Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, "%02X", bytes[i]);

* Update BattlegroundAV.cpp

* more macos12 fixit

* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
UltraNix 8cb88cce52 fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mec… (#14541)
* fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mechanic.

Fixes #13988

* buildfix.

* Update src/server/scripts/Outland/CoilfangReservoir/underbog/boss_the_black_stalker.cpp

Co-authored-by: offl <offl@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-01-07 20:28:22 +01:00
Kitzunu 7b774c8141 fix(Core/Spell): Roll 'dem Bones (#14522)
* fix(Core/Spell): Roll 'dem Bones

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14357

* Partial cp of https://github.com/TrinityCore/TrinityCore/commit/029527365f1763c45e8668c16ecd25ba7553bb22

Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com>

* newline pleb

Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-01-07 20:05:42 +01:00
UltraNix 14f3b444ae fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… (#14054)
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.

Fixes #6674

* Update.
2023-01-06 00:52:05 +01:00
Kitzunu 4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix eb3f80ceff fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: … (#13518)
fix(Core/Spells): Implemented SPELL_HIT_TYPE_SPLIT hit type. Source: TrinityCore.

Fixes #13306
2022-10-29 07:13:36 -03:00
M'Dic 55a5684c87 Add (core): Effect Transmit Anticheat Helper (#13447)
Add (core): Anticheat Helper
2022-10-23 09:19:35 -04:00
UltraNix e390087efd feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… (#13050)
...yCore.
2022-10-08 14:34:52 -03:00
Angelo Venturini ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini e05f61d1b3 fix(Core/QAston): fixed shields oneshotting (#13271)
* fix(Core/QAston): fixed shields oneshotting

* fix build
2022-10-04 19:37:48 +02:00
IntelligentQuantum cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
SoglaHash fa00250323 fix(CORE/Spells): Fix Scaling of some Guardians (#12625)
* fix(CORE/Spells): Fix Scaling of some Guardians

Guardians summoned by engineering and items have wrong scaling.

This will fix Engineering items having the wrong stat scaling.

Also fix some Guardians summoned by items to have appropriate level and
stats.
Closes AzerothCore issue #12446

* Fix whitespace

* fix codestyle
2022-10-01 22:35:09 +02:00
Maelthyr 1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
ZhengPeiRu21 1ddd884d6a feat(Core): Implement SP Bonus Coefficients from DBC (#12562)
* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/1826437c094966ae339a154844df8587b2122888)

* Co-authored by: ariel- <ariel-@users.noreply.github.com>

* feat(Core): Implement SP Bonus Coefficients from DBC

* Several coefficient corrections

* Fix spell_dru_lifebloom
2022-09-17 11:09:04 +02:00
UltraNix 406f2bcd02 fix(Core/Battlegrounds): Fixed setting proper winner team at the end … (#12868)
fix(Core/Battlegrounds): Fixed setting proper winner team at the end of battleground.

Fixes #11717
Fixes #12688
2022-08-31 06:40:32 -03:00
UltraNix 8c1b729375 fix(Core/Spells): Removed any triggered auras on glyph removal. (#12168)
* fix(Core/Spells): Removed any triggered auras on glyph removal.

Fixes #11939

* Update.
2022-06-28 16:19:35 -04:00
UltraNix 1bb343c847 fix(Core/Professions): Players should be able to update gathering ski… (#12033)
fix(Core/Professions): Players should be able to update gathering skill only once per gameobject.

Fixes #11918
2022-06-19 07:46:56 -04:00
Maelthyr d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: https://github.com/TrinityCore/TrinityCore/commit/74af880217fc567c9949d7557408718af889402f

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: https://github.com/TrinityCore/TrinityCore/commit/74af880217fc567c9949d7557408718af889402f

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
Nefertumm 396fd35ed5 fix(Core/Spells): Implement SPELL_EFFECT_ACTIVATE_OBJECT (#11648)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-06-13 21:10:31 -03:00
Maelthyr 32334f5f14 refactor(Core/Unit): minor changes for the combat system (#11904)
Cherry-pick from TC: https://github.com/TrinityCore/TrinityCore/pull/19966

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-13 19:40:29 -03:00
UltraNix 55720eedd3 fix(Scripts/Spells): Sweeping Strikes - improvements. (#11666)
* fix(Scripts/Spells): Sweeping Strikes - improvements.

Fixes #11594

* Buildfix.
2022-05-23 05:49:56 -03:00
UltraNix 914ea4f9c3 fix(Core/Items): Properly transfer enchantment durations from old to … (#11828)
fix(Core/Items): Properly transfer enchantment durations from old to newly created/summoned items.

Fixes #11687
2022-05-23 04:27:53 -03:00
UltraNix 99f1cd84e2 fix(Core/Spells): Improvements to Far Sight spell: (#11683)
* fix(Core/Spells): Improvements to Far Sight spell:

Far Sight should not interrupt while casting another spell.
Corrected setting Far Sight object as an active object.
Fixed grid activation range for active dynamic objects.
When Far Sight is over, the camera be reset to player.
Enable swapping camera between Far Sight and Sentry Totem.
Fixes #6368

* Update.

* Update.
2022-05-23 04:26:51 -03:00
Maelthyr c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00