From 78ef336d61b08140ebcda588c26134d694f4584a Mon Sep 17 00:00:00 2001 From: Andrew <47818697+Nyeriah@users.noreply.github.com> Date: Fri, 4 Sep 2026 17:42:13 -0300 Subject: [PATCH] docs(agents): require upstream author credit for mirrored code (#27504) --- .agents/docs/self-review-rules.md | 6 ++++++ AGENTS.md | 1 + 2 files changed, 7 insertions(+) diff --git a/.agents/docs/self-review-rules.md b/.agents/docs/self-review-rules.md index 952304bbc3..b41cba5399 100644 --- a/.agents/docs/self-review-rules.md +++ b/.agents/docs/self-review-rules.md @@ -24,6 +24,12 @@ Every change gets the full review; go deeper the farther it can reach: - SQL: beyond the usual review, watch for the classic side effect — a DELETE/UPDATE whose WHERE clause catches rows it shouldn't. +## Upstream attribution + +Any changed code, mechanism, or data mirrored from another core must carry that upstream commit's +author via `--author` (extras as `Co-authored-by`) with the template's cherry-pick box checked; a +missing credit is a finding. + ## In-game testing PRs are expected to be tested in-game, which the reviewer cannot do. Never guess what the diff --git a/AGENTS.md b/AGENTS.md index 1c3d4b3bbe..fd721f8b5e 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -10,6 +10,7 @@ AzerothCore is a C++ MMORPG server emulator for World of Warcraft 3.3.5a (WotLK) - **Prefer live-stack e2e to debug/validate player-visible behaviour** when a local auth+world+MySQL stack is available (protocol, combat, quests, loot, death, multi-bot). See `e2e/README.md` and AzerothGhost `e2e/LLM_GUIDE.md`. Do not invent e2e for pure unit-sized logic — see `.agents/docs/e2e-policy.md`. - **Scratch e2e only under `e2e/local/`** (gitignored). Never commit throwaway debug tests. Promote keepers into `e2e/suites/` or `e2e/smoke/`. - Planning docs go in `.agents/plans//` (gitignored), named `..md` (`PLAN`, `REQUIREMENTS`, `ANALYSIS`, …). +- **Credit upstream authors.** Code, a mechanism, or data mirrored from another core (TrinityCore, cMaNGOS, …) is committed with `--author` naming the original commit's author (extra sources as `Co-authored-by`), even when rewritten against AC or confirmed by own sniffs; find them in the upstream file's commit history. ## Mandatory reading per task