mirror/azerothcore-wotlk
1
0
Fork 1
mirror of https://gitcode.com/GitHub_Trending/az/azerothcore-wotlk.git synced 2026-10-10 07:06:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(Scripts/World): guard server mail login callback against logged-o… (#27827)

Browse Source
This commit is contained in:
Kitzunu
2026-09-27 05:52:20 -03:00
committed by GitHub
parent 82b7042c67
commit 3d28fa72d7
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/server/scripts/World/server_mail.cpp
+8 -3
View File
@@ -35,7 +35,8 @@ public:
if (!session)
return;
uint32 playerGUID = player->GetGUID().GetCounter();
ObjectGuid playerGuid = player->GetGUID();
uint32 playerGUID = playerGuid.GetCounter();
bool isAlliance = player->GetTeamId() == TEAM_ALLIANCE;
for (auto const& [mailId, servMail] : serverMailStore)
@@ -45,10 +46,14 @@ public:
stmt->SetData(1, mailId);
// Capture servMail by value
auto callback = [session, servMailWrapper = std::reference_wrapper<ServerMail const>(servMail), isAlliance](PreparedQueryResult result)
auto callback = [session, playerGuid, servMailWrapper = std::reference_wrapper<ServerMail const>(servMail), isAlliance](PreparedQueryResult result)
{
ServerMail const& servMail = servMailWrapper.get(); // Dereference the wrapper to get the original object
Player* sessionPlayer = session->GetPlayer();
if (!sessionPlayer || sessionPlayer->GetGUID() != playerGuid)
return;
if (!result)
{
uint32 money = isAlliance ? servMail.moneyA : servMail.moneyH;
@@ -56,7 +61,7 @@ public:
std::vector<ServerMailCondition> const& conditions = servMail.conditions;
sServerMailMgr->SendServerMail(
session->GetPlayer(),
sessionPlayer,
servMail.id,
servMail.senderEntry,
money,