Commit Graph

114 Commits

Author SHA1 Message Date
Jelle Meeus 845fa07aad fix(Scripts/Ulduar): update Boss Keepers, Gossip Keepers, Yogg Keepers, Yogg-Saron (#18943)
* gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

* refactor: remove _keepersGUID[4]

* make keeper auras only target players, remove apply scale immunity to well/keepers

include caster in cast

* update keeper flags

* summon and despawn gossip keepers

spawn only if fight done

add intro spell and handle outro

fix off by 1

fix casting simple teleport, only spawn after teleporting

remove empty line

* add teleport to shared ulduar.h

* each keeper triggers their own gossip spawn

* update is called in Reset(), no need to do it here

* add SpellHit override to Freya, Hodir

* Freya, Hodir: use scheduler to schedule post-fight teleport

* JustSummoned rename cr to summon

* sanity well summons are handled by freya instead of sara

* rename pCreature to creature

* keeper use RegisterUlduarCreatureAI

* Freya, Hodir, Thorim: increase despawn time

* despawn tentacles, sanity wells after fight

despawn tentacles after fight

* change order of teleport spells

* am missing header?
2024-05-25 12:06:21 -03:00
Jelle Meeus d44c8990c1 fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux (#18807)
* fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux

* remove blank line

* remove four_horsement_consumption SpellScript

* update comment
2024-05-11 13:54:26 +01:00
Anton Popovichenko 22f2a8f731 fix(Core/Spell): Fix crash in Rogue T10 4P Bonus (#18413) 2024-02-25 19:55:32 -03:00
Nathan Handley df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
天鹿 bf87cc5230 fix(Core): Build (#17989)
Update spell_generic.cpp
2023-12-11 09:54:44 -03:00
Angelo Venturini 31b66ad80a fix(Core/SSC): Fix Lady Vashj summons (#17982) 2023-12-11 02:46:12 -03:00
Winfidonarleyan eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu 5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
avarishd bc688c2a51 fix(Core/Spells): Script Choking Vines (#17615)
* fix(DB/Custom): Choking Vines should stack from different sources

* script spell

* comment
2023-11-02 08:53:45 -03:00
avarishd 39bad395c2 fix(Core/Spells): Script Yeh'kinya's Bramble (#17516)
* fix(Core/Spells): Script Yeh'kinya's Bramble

* rogue screechers
2023-10-21 08:10:00 -03:00
avarishd 2c28cc0eb7 fix(DB/Items): Unhatched Jubling Egg obtaining + RP (#17478) 2023-10-20 20:39:04 -03:00
avarishd e30718db36 fix(Core/Spells): Script Scourge Banner (#17523)
* fix(Core/Spells): Script Scourge Banner

* correct statecheck
2023-10-16 23:13:54 +02:00
avarishd 91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00
Francesco Borzì 5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Kitzunu 6185b1d73b fix(Core/Events): Implement Spirit of Competition event (#16963)
* fix(Core/Events): Implement Spirit of Competition event

Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* more stuff

* bye bye magic numbers

* fix dberrors

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* commoneers

* Update src/server/game/Battlegrounds/Battleground.cpp

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* ci

* Update rev_1691529514989936100.sql

* unnecessary whitespace

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update Battleground.cpp

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2023-08-20 00:41:44 +02:00
avarishd 66daf97144 fix(Core/Spells): Curse of Pain (#16844)
* fix(Core/Spells): Curse of Pain

* ocd
2023-07-29 21:51:15 +02:00
avarishd 998bb9d54b fix(Core/Spells): Shriveling Gaze (#15939)
* fix(Core/Spells): Shriveling Gaze

* comment out unused parameter

* again
2023-07-08 10:03:03 -03:00
M'Dic 7e58650cf5 revert(Core): ChrRace.dbc full implementation (#16114)
* revert (core): ChrRace.dbc full implementation

we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that  there is

* revert

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql

* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic 3eae4c5713 fix(core/dbc): improve ChrRace DBC handling (#14843)
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508

Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2023-04-28 01:29:33 +02:00
Skjalf 5dcea531b5 fix(Scripts/ShadowLabyrinth): Update Murmur script (#15970)
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-04-17 00:19:12 -03:00
Timothy Vaccarelli a8a3011278 fix(Script/Spell): Fix animal blood pool effect and position (#15918)
Adapted from TC Commits 3ddc6e70df0401a0677bef536e6b0e46e3dbf9e9 and cc3293c0023b36434747190103a1f0ffee0f8488

Co-authored-by: sirikfoll <sirikfoll@hotmail.com>
Co-authored-by: Rushor <rushor@github.com>
2023-04-12 08:07:00 -03:00
avarishd 971e2f538e fix(DB/SAI): Outland Basilisks. (#15578)
* fix(DB/SAI): Outland Basilisks.

* update

* update

* sniff for 20283 (Marshrock Stomper)

Co-Authored-By: Gultask <100873791+Gultask@users.noreply.github.com>

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-04-09 15:54:53 -03:00
Gultask ce40ed6278 fix(Core/Spells): Improve Feign Death scripts (#15496)
init

Co-authored-by: offl <11556157+offl@users.noreply.github.com>
2023-03-20 02:49:01 -03:00
UltraNix a375e713f9 fix(Core/Spells): Casting Basaic Campfire should give cooking skill. (#15194) 2023-03-13 08:18:00 -03:00
UltraNix 479c965c4e fix(Scripts/Spells): Fixed Rogue T10 4P bonus. (#15336) 2023-03-11 16:58:44 -03:00
Kitzunu bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Kitzunu f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
M'Dic 437d93926f fix (core): macos12 depreciation workflow error / security CWE-120 (#14746)
* fix (core): macos12 depreciation workflow error

Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, "%02X", bytes[i]);

* Update BattlegroundAV.cpp

* more macos12 fixit

* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
Kitzunu 4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix 4860989242 fix(Scripts/Spells): Fixed level requirements for Blade Ward and Bloo… (#14107)
fix(Scripts/Spells): Fixed level requirements for Blade Ward and Blood Draining enchants.

Fixed Blood Draining proc.
Fixes #12131
2022-12-12 13:57:03 +01:00
Angelo Venturini 72b446fb12 fix(Core/Scripts): Bloodscale Enchantress/Rajis Fyashe freezing circle (#13963)
Co-authored-by: Eridium <killyana@users.noreply.github.com>
Co-authored-by: Lucas Nascimento <keader.android@gmail.com>

Co-authored-by: Eridium <killyana@users.noreply.github.com>
Co-authored-by: Lucas Nascimento <keader.android@gmail.com>
2022-12-11 11:35:08 -03:00
Angelo Venturini ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini be423a91b5 fix: Crash (#13241) 2022-10-03 16:14:43 -03:00
IntelligentQuantum cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
Maelthyr 1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
UltraNix 91daa6cb78 fix(Scripts/Spells): Prevent from stacking basic campfires on each ot… (#13037)
fix(Scripts/Spells): Prevent from stacking basic campfires on each other.

Fixes #9369
2022-09-25 10:44:33 -03:00
Skjalf 9e7aae74ac fix(Scripts/Spells): Fix Itch (26078) not applying Vekniss Catalyst (#12930) 2022-09-03 04:01:39 -03:00
UltraNix 314e6a84f7 fix(Scripts/Spells): Fixed T3 4P Frostfire Regalia bonus not proccing. (#12583) 2022-08-01 17:53:53 -03:00
Skjalf 5b14267159 fix(Scripts/Spells): Script spell Itch (AQ20) and improve Consume (AQ20) (#12502) 2022-07-25 12:13:06 -03:00
Skjalf 565e39ac55 fix(Scripts\Spells): Consume (AQ) (#12448) 2022-07-20 13:49:39 -03:00
Maelthyr d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: https://github.com/TrinityCore/TrinityCore/commit/74af880217fc567c9949d7557408718af889402f

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: https://github.com/TrinityCore/TrinityCore/commit/74af880217fc567c9949d7557408718af889402f

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
天鹿 e09622b191 fix(Core/Item): Fix TrinketUpdate (#11571)
* Update spell_generic.cpp

* Add files via upload

* Update and rename rev_1650656505854517188.sql to rev_1651226361653358110.sql

* Update and rename rev_1651226361653358110.sql to rev_1651231168158458211.sql

* Update rev_1651231168158458211.sql
2022-06-14 23:15:00 -03:00
Maelthyr c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
Skjalf 26c66e0d79 chore(Scripts/Spells): Remove a few aura types being passed as spells in the validator (#11576) 2022-04-29 20:17:03 -03:00
Kitzunu 2bef6b497d fix(Scripts/Spells): Validate some spells in spell_generic (#11549)
* fix(Scripts/Spells): Validate some spells in spell_generic

* Update src/server/scripts/Spells/spell_generic.cpp
2022-04-28 15:49:56 -03:00
IntelligentQuantum c93a84e821 feat(Spell/Scripts): Move Spell gen remove impairing auras to spell scripts (#11104) 2022-04-18 19:35:07 +02:00
Kitzunu 535c7451a2 feat(Core/Unit): New helpers for DynamicFlags (#11230)
* feat(Core/Unit): New helpers for DynamicFlags

* cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/d611925dc7ab2b3f19c5ee9e0f75b8dfb6de1291)

Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* oopsie

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-04-01 07:14:29 -03:00
IntelligentQuantum 7a294787d3 feat(Scripts/Spell): Teleporting to Script
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-04-01 07:03:22 -03:00
UltraNix 14edda6c90 fix(Core/Players): Fixed setting player's zone id to unknown value. (#10996)
* fix(Core/Players): Fixed setting player's zone id to unknown value.

Fixed #10945

* Update.

* Update.
2022-04-01 06:59:12 -03:00
Kitzunu 856aed6fc6 feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 (#11227) 2022-03-30 07:59:42 -03:00